Move build summary extraction logic out #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorin-florea
commented
Aug 22, 2023
jthurne
approved these changes
Aug 23, 2023
erichaagdev
reviewed
Aug 23, 2023
etiennestuder
requested changes
Aug 23, 2023
erichaagdev
reviewed
Aug 25, 2023
jthurne
force-pushed
the
sorin/consolidation
branch
from
aa746ec to
77b69fc
Compare
jthurne
force-pushed
the
sorin/consolidation
branch
from
77b69fc to
48d7169
Compare
|
Successfully ran the below experiments at commit 0e2028a. |
jthurne
force-pushed
the
sorin/consolidation
branch
from
0e2028a to
8721a55
Compare
erichaagdev
reviewed
May 9, 2024
|
When I invoke a script I get this right at the start:
Message: /Users/eric/Projects/gradle/gradle-enterprise-gradle-build-validation/local/lib/scripts/exit-code.sh: line 3: SUCCESS: readonly variableTo reproduce it, just run: ./01-validate-incremental-building.sh \
-r git@github.com:gradle/gradle-build-scan-quickstart.git \
-c 710a21dad423192a0ea2d9aea77f381f40eb8a6a \
-t 'build' \
-s https://ge.solutions-team.gradle.com |
|
This is probably an issue with the jar, but I noticed this in debug mode:
|
jthurne
reviewed
May 9, 2024
Fixed in 9fadce5 |
Resolve build scan summary dependencies
erichaagdev
reviewed
May 23, 2024
Co-authored-by: Eric Haag <ehaag@gradle.com> Signed-off-by: Sorin Florea <sorin.florea.v@gmail.com>
|
Did some testing and all looks good up to this point. Each distribution has their respective license and scripts are working as expected. |
erichaagdev
reviewed
Jun 12, 2024
Co-authored-by: Eric Haag <ehaag@gradle.com> Signed-off-by: Jim Hurne <jhurne@gradle.com>
* origin/main: Bump com.google.guava:guava from 33.2.0-jre to 33.2.1-jre Bump Gradle Wrapper from 8.7 to 8.8 Bump org.apache.maven:maven-core from 3.9.6 to 3.9.7 Bump com.gradle.develocity from 3.17.3 to 3.17.4 Bump com.gradle.develocity from 3.17.2 to 3.17.3
The Develocity Maven Extension is covered by the same terms of use as the fetch-build-scans utility is, so we want it to be in the same directory.
From the perspective of this project, it's a third-party open source dependency.
The Gradle Enterprise Maven Extension was renamed to the Develocity Maven Extension in version 1.21. The API was also updated for the product name change. Unfortunately, this broke compatibility with the Build Validation Scripts. This commit fixes the incompatibility. The fix works by updating the configure-gradle-enterprise-maven-extension to define and register two listeners: a GradleEnterpriseListener and a DevelocityListener. If an older version of the Gradle Enterprise Maven Extension is used, it will load the GradleEnterpriseListener. If a newer version of the Develocity Maven Extension is used, then it will load the DevelocityListener. The Develocity Maven Extension Adapters are used to eliminate duplication between the two different listeners. This commit also creates a "fat jar" so that the develocity-maven-extention-adapters jar does not have to be manually added to the classpath. The project compiles agianst an older version of Maven to ensure compatibility with projects using an older version of Maven. **Remove unused variables and suppress deprecation warnings** Unused warnings were previously suppressed because the main classes aren't used directly. However, this suppressed other unused warnings and hid a few things that are not actually used. So this commit un-supresses unused warnings and removes the unused variables and parameters. The attempt to suppress deprecation warnings on the ConfigureGradleEnterprise class wasn't working because the deprecated classes are referenced in import statements. The class was updated to use the fully qualified name of the deprecated classes. --------- Signed-off-by: Jim Hurne <jhurne@gradle.com> Co-authored-by: Eric Haag <ehaag@gradle.com> Co-authored-by: Brian Demers <brian.demers@gmail.com>
jthurne
force-pushed
the
sorin/consolidation
branch
from
9c8ed3c to
b51d887
Compare
* origin/main: Add support for the renamed Develocity Maven Extension (#624)
Sync is slightly better because it effectively resets the output directory before copying. That way, old files that shouldn't be included anymore are not included (and avoids having to run ./gradlew clean).
* origin/main: Bump github/combine-prs from 5.0.0 to 5.1.0 Bump Gradle Wrapper from 8.8 to 8.9 Migrated to gradle/actions/setup-gradle@v3 and removed info logging from build-verification Migrated github actions gradle executions to accessToken auth and renamed the secret to develocity naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the build scan summary logic into a separate jar file that is built externally to the build validation scripts.
It also restructures the final distribution.
New Gradle scripts distribution layout:
New Maven scripts distribution layout: